-
Notifications
You must be signed in to change notification settings - Fork 802
[lib] Replace uses of add_meow_t with plain cv-qualifiers
#7851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There may be additional uses of |
Those should not be in this pull request. |
Other uses of For |
source/utilities.tex
Outdated
| // \ref{utility.as.const}, \tcode{as_const} | ||
| template<class T> | ||
| constexpr add_const_t<T>& as_const(T& t) noexcept; | ||
| constexpr const T& as_const(T& t) noexcept; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes the mangled name for std::as_const specializations, but I don't think we need to care about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a normative change though, so not editorial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood; @frederick-vs-ja , please remove this change from the present editorial pull request and (at your option) create an LWG issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jensmaurer PTAL?
...except for [tab:meta.trans.cv], because the wording change for `add_cv` seems a bit non-trivial, and for the return type of `as_const`, because the the change would affect mangled name.
a820113 to
3f3f6a7
Compare
...except for [tab:meta.trans.cv], because the wording change for
add_cvseems a bit non-trivial, and for the return type ofas_const, because the the change would affect mangled name.Fixes #7845.